Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated schemas following MaterialEntity ratification, plus updated… #121

Merged
merged 8 commits into from
Feb 16, 2024

Conversation

tucotuco
Copy link
Collaborator

… vocabulary for basisOfRecord.

@MattBlissett
Copy link
Member

Sorry @tucotuco, I have accidentally pushed a fix to the generation script to master, I meant to make a PR: tdwg/dwc@abde0cc

The record level terms were missing from the taxon core definition.

@MattBlissett
Copy link
Member

Comments from previous PR:

These XML files are now generated with this script using the term_versions.csv file as the authority for term definitions and comments. If there are desired changes to how the XML files are produced, please submit an issue citing this script.

Note that these submissions do not address these open issues:
#96
#73

If any of these changes are desired, please alert by submitting an issue so we can change the generation script.

This issue has been addressed with the new eventType field:
#63

MattBlissett
MattBlissett previously approved these changes Sep 25, 2023
Copy link
Member

@MattBlissett MattBlissett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now looks fine to me. I added the missing terms to the Taxon core, and moved the BoR vocabulary to the sandbox, manually updating the link to it.

@tucotuco
Copy link
Collaborator Author

OK, I was going to check the outcome of running the script. I was worried that record-level terms at the end of the list would make for an inconsistency in presentation in the IPT.

@MattBlissett
Copy link
Member

I don't know why, but they' are at the end of the file in the current Taxon core definition: https://github.com/gbif/rs.gbif.org/blob/master/core/dwc_taxon_2022-02-02.xml#L53-L65

@tucotuco
Copy link
Collaborator Author

Hmm, they were in the version from 2015 too. I guess I will worry less. Still, I will run through the process and commit a new taxon core with a version dated today just to make sure the pipeline works correctly...

@tucotuco
Copy link
Collaborator Author

OK, that should take care of all the recent changes in generated versions of the core schema definitions.

@MattBlissett
Copy link
Member

I think you've forgotten to commit the new ones.

@tucotuco
Copy link
Collaborator Author

I had forgotten to add them. Doh! Fixed now.

MattBlissett
MattBlissett previously approved these changes Sep 25, 2023
@timrobertson100
Copy link
Member

@MattBlissett - I see you've approved these but didn't merge. Do these reflect everything we expect to now test in ipt.gbif.org and gbif-uat.org or is there a known reason to hold them back?

Thanks

@MattBlissett
Copy link
Member

It's everything we need for UAT testing, and it's fine to merge it. (But as it's a sort of deployment, I won't do it now.)

@timrobertson100
Copy link
Member

Thanks

@MattBlissett MattBlissett merged commit f01fa72 into master Feb 16, 2024
@MattBlissett MattBlissett deleted the dwcMaterialEntity branch February 16, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants