Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provisional core and extension files for 2021-07-15 ratifications. #72

Merged
merged 4 commits into from
Aug 30, 2021

Conversation

tucotuco
Copy link
Collaborator

Functionality (validity of XML files) depends on #71.

Vocabulary functionality for establishmentMeans, degreeOfEstablishment, and pathway depends on the creation of those and placement in vocabulary folder. I'm happy to create those if desired, but see #21 (comment).

sandbox/core/dwc_event_2021-08_16.xml Outdated Show resolved Hide resolved
sandbox/core/dwc_taxon_2021-08_16.xml Outdated Show resolved Hide resolved
sandbox/extension/identification_history_2021-08_16.xml Outdated Show resolved Hide resolved
sandbox/extension/resource_relationship_2021-08_16.xml Outdated Show resolved Hide resolved
@tucotuco
Copy link
Collaborator Author

@MattBlissett I will make updates to address these issues.

@tucotuco
Copy link
Collaborator Author

@MattBlissett I think I have fixed everything you detected.

@tucotuco
Copy link
Collaborator Author

That last commit I intended to new in a new branch, but I selected this one instead. That commits depends on merging #77.

@MattBlissett
Copy link
Member

I think the files are fine, but the vocabularies are in sandbox/dwc/... rather than sandbox/vocabularies/dwc/..., which will be needed so the IPT picks them up.

@tucotuco
Copy link
Collaborator Author

Sorry, I followed the pattern of the one production Darwin Core vocabulary - /vocabulary/dwc/basis_of_record.xml and created a dwc directory in sandbox/vocabularies.

The outdated thesaurus references to these new vocabularies will have to be updated in sandbox/core/dwc_occurrence_2021-08-16.xml where they say

http://rs.gbif.org/vocabulary/dwc/basis_of_record.xml
http://rs.gbif.org/vocabulary/gbif/establishmentmeans_2020-10-13.xml
http://rs.gbif.org/vocabulary/gbif/degreeofestablishment_2020-10-13.xml
http://rs.gbif.org/vocabulary/gbif/pathway_2020-10-13.xml

@MattBlissett MattBlissett merged commit c82d4bc into gbif:master Aug 30, 2021
@tucotuco
Copy link
Collaborator Author

It is a good time to consider the proposal in issue #73 and remove https://github.com/gbif/rs.gbif.org/blob/master/sandbox/core/dwc_event_2021-08-16.xml#L16. I did not do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants