Lift ndarray compatibility into Buffer<T>
#494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… block reading without `array` feature. `Rasterband::read_block` renamed `Rasterband::read_block_as_array` to be consistent with `read_as` vs. `read_as_array`.
metasim
force-pushed
the
feature/buffer-read-block
branch
from
9095de2
to
39249c1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
to use internal `Buffer` type, and implemented conversion traits between the types.
metasim
commented
Dec 17, 2023
metasim
commented
Dec 17, 2023
metasim
commented
Dec 17, 2023
metasim
commented
Dec 17, 2023
metasim
changed the title
RasterBand::read_block using the Buffer APIndarray compatibility into Buffer<T>
lnicola
reviewed
Dec 18, 2023
lnicola
reviewed
Dec 18, 2023
lnicola
reviewed
Dec 18, 2023
lnicola
reviewed
Dec 18, 2023
lnicola
reviewed
Dec 18, 2023
lnicola
reviewed
Dec 18, 2023
lnicola
reviewed
Dec 18, 2023
Made fields of `Buffer<T>` private.
metasim
commented
Dec 18, 2023
lnicola
reviewed
Dec 20, 2023
lnicola
reviewed
Dec 20, 2023
lnicola
reviewed
Dec 20, 2023
lnicola
reviewed
Dec 20, 2023
lnicola
reviewed
Dec 20, 2023
lnicola
reviewed
Dec 20, 2023
lnicola
reviewed
Dec 20, 2023
Co-authored-by: Laurențiu Nicola <[email protected]>
…buffer-read-block
…nto feature/buffer-read-block
lnicola
reviewed
Dec 21, 2023
lnicola
reviewed
Dec 21, 2023
lnicola
reviewed
Dec 21, 2023
lnicola
reviewed
Dec 21, 2023
Co-authored-by: Laurențiu Nicola <[email protected]>
…nto feature/buffer-read-block
lnicola
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Buffer<T>andndarray::Array2<T>.IntoIterator,IndexandIndexMutforBuffer<T>.Buffer<T>::sizeis now private and accessed via `Buffer::shape().Buffer<T>::datais now private and accessed via `Buffer::data().Rasterband::read_as_array, changed signature ofRasterband::read_blockto return aBuffer<T>.Rasterband::writeandRasterband::write_blocknow require a&mut Buffer<T>to handle possible case of drivers temporarily mutating input buffer.cc: @mwielocha