fix(secret): Retrieve client_secret if not provided #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germainlefebvre4
force-pushed
the
fix/client-secret
branch
2 times, most recently
from
2f3b0e8
to
c4cb302
Compare
germainlefebvre4
force-pushed
the
fix/client-secret
branch
2 times, most recently
from
b24ac0c
to
ababd6d
Compare
germainlefebvre4
force-pushed
the
fix/client-secret
branch
from
ababd6d
to
bd90a97
Compare
|
Perhaps we should push this behavior in the Tado() class: make the client certificate optional there. That would also unbreak the compatibility with (very) old code that constructs Tado() with only two arguments. Not sure how many of such users there are though... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.