Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank menu "Manage Reserved Names" #63

Closed
wvro-org opened this issue Jan 1, 2024 · 5 comments
Closed

Blank menu "Manage Reserved Names" #63

wvro-org opened this issue Jan 1, 2024 · 5 comments
Assignees
Labels
bug Something isn't working Control panel

Comments

@wvro-org
Copy link
Contributor

wvro-org commented Jan 1, 2024

Registry -> TLDs -> Managed Reserved Names
Screenshot 2024-01-02 at 00 32 02

@getpinga getpinga self-assigned this Jan 1, 2024
@getpinga getpinga added bug Something isn't working Control panel labels Jan 1, 2024
@getpinga
Copy link
Contributor

getpinga commented Jan 1, 2024

Thanks, I can confirm. There should be a logic for adding new reserved names, when the DB is empty. I'll work on it.

@wvro-org
Copy link
Contributor Author

wvro-org commented Jan 1, 2024

manually added org.example.com ... to db

Screenshot 2024-01-02 at 00 54 40 and when the input field is clear(aka del reserved name) it asks to enter domain... and when manually delet reserved domains from db it's the same "blank" issue and it would be greate to be able to specify exact reserved domain not just example without .com

getpinga added a commit that referenced this issue Jan 2, 2024
@getpinga
Copy link
Contributor

getpinga commented Jan 2, 2024

Please replace this file https://github.com/getnamingo/registry/blob/main/cp/app/Controllers/SystemController.php and try again

  • Now when empty, will ask to enter at least one domain in each category, there will not be the blank issue.
  • If you delete all, it will still ask to enter at least one name. Still working on this.
  • About entering the exact domain ,for the moment I can not change that, as it is designed to have reserved names across all TLDs added to the system. That's why there is no TLD.

@wvro-org
Copy link
Contributor Author

wvro-org commented Jan 2, 2024

Seams to me works fine
Screenshot 2024-01-02 at 15 25 20

however check domain only one time displayed "blue" error / Domain "org.test"/"edu.test" is not available: domain reserved/restricted (sorry no screen)

or not.... works fine...

and now somehow it allowed to delete "reserved" domains and the is only one field with "restricted" domain
and issue with no field for "reserved" domains..... and manually changed in db type from restricted to reserved and now thereis no field for restricted domains...
Screenshot 2024-01-02 at 15 47 16
Screenshot 2024-01-02 at 15 47 48

@getpinga
Copy link
Contributor

This also got fixed. Please test and reopen if still having an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Control panel
Projects
None yet
Development

No branches or pull requests

2 participants