Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 468 #469

Merged
merged 3 commits into from
Jan 12, 2022
Merged

fix 468 #469

merged 3 commits into from
Jan 12, 2022

Conversation

beliaev-maksim
Copy link
Collaborator

@beliaev-maksim beliaev-maksim commented Jan 12, 2022

closes #468

Issue is caused by new behavior of decorator, which allows to run it as static responses.activate as well as a function call like responses.activate(registries=). mypy cannot treat it really well. See pydantic/pydantic#2052

In order to avoid this, we will need to overload decorator definition in typing.

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #469 (8fef685) into master (6e7d466) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #469   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines         2012      2012           
=========================================
  Hits          2012      2012           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e7d466...8fef685. Read the comment docs.

@markstory markstory merged commit 0852c09 into getsentry:master Jan 12, 2022
@beliaev-maksim beliaev-maksim deleted the fix_468 branch January 12, 2022 15:23
adamtheturtle added a commit to adamtheturtle/requests-mock-flask that referenced this pull request Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@responses.activate triggers untyped decorator error in mypy
2 participants