-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mbeliaev/decorator #524
mbeliaev/decorator #524
Conversation
Codecov Report
@@ Coverage Diff @@
## master #524 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 2378 2421 +43
=========================================
+ Hits 2378 2421 +43
Continue to review full report at Codecov.
|
assert_mock = std_mock.patch.object( | ||
target=responses, | ||
attribute="assert_all_requests_are_fired", | ||
new=assert_all_requests_are_fired, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we run into more problems with nested decorators mutating the same global object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point, I think I need to run a test and add it to the test suite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markstory
value is applied from the function where requests
is called. I think this is reasonable
Co-authored-by: Mark Story <[email protected]>
@markstory |
# Conflicts: # responses/__init__.pyi
# Conflicts: # CHANGES # responses/__init__.py # responses/__init__.pyi
closes #183