Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbeliaev/decorator #524

Merged
merged 11 commits into from
Apr 5, 2022
Merged

mbeliaev/decorator #524

merged 11 commits into from
Apr 5, 2022

Conversation

beliaev-maksim
Copy link
Collaborator

closes #183

@codecov
Copy link

codecov bot commented Mar 22, 2022 •
edited
Loading

Codecov Report

Merging #524 (ccd1f59) into master (bf30737) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #524   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         2378      2421   +43     
=========================================
+ Hits          2378      2421   +43
Impacted Files Coverage Δ
responses/__init__.py 100.00% <100.00%> (ø)
responses/tests/test_responses.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf30737...ccd1f59. Read the comment docs.

@beliaev-maksim beliaev-maksim mentioned this pull request Mar 22, 2022
Merged
markstory
markstory reviewed Mar 23, 2022
View reviewed changes
responses/__init__.py Outdated Show resolved Hide resolved
responses/__init__.py
Comment on lines +145 to +149
assert_mock = std_mock.patch.object(
target=responses,
attribute="assert_all_requests_are_fired",
new=assert_all_requests_are_fired,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we run into more problems with nested decorators mutating the same global object?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, I think I need to run a test and add it to the test suite

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markstory
value is applied from the function where requests is called. I think this is reasonable

@beliaev-maksim
Copy link
Collaborator Author

@markstory
can you please review again?
I have some changes dependent on #524 and #522

@beliaev-maksim
Merge branch 'master' into mbeliaev/decorator
7d07978 
# Conflicts:
#	responses/__init__.pyi
@beliaev-maksim
Merge branch 'master' into mbeliaev/decorator
ccd1f59 
# Conflicts:
#	CHANGES
#	responses/__init__.py
#	responses/__init__.pyi
@markstory markstory merged commit 9b9ac96 into getsentry:master Apr 5, 2022
@beliaev-maksim beliaev-maksim deleted the mbeliaev/decorator branch April 5, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markstory markstory Awaiting requested review from markstory

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add or enable a strict version of 'activate' decorator
2 participants
@beliaev-maksim @markstory