Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix retry error #575

Merged
merged 5 commits into from
Aug 29, 2022
Merged

fix retry error #575

merged 5 commits into from
Aug 29, 2022

Conversation

beliaev-maksim
Copy link
Collaborator

replace exception by RetryError according to requests implementation: https://github.com/psf/requests/blob/177dd90f18a8f4dc79a7d2049f0a3f4fcc5932a0/requests/adapters.py#L549

closes #572

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #575 (93f26e9) into master (d49f829) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #575   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         2644      2660   +16     
=========================================
+ Hits          2644      2660   +16     
Impacted Files Coverage Δ
responses/__init__.py 100.00% <100.00%> (ø)
responses/matchers.py 100.00% <100.00%> (ø)
responses/tests/test_matchers.py 100.00% <100.00%> (ø)
responses/tests/test_responses.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@1Mark
Copy link

1Mark commented Aug 24, 2022

LGTM

Copy link

@1Mark 1Mark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@jared-duo jared-duo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

responses/__init__.py Outdated Show resolved Hide resolved
@markstory markstory merged commit e6d0166 into getsentry:master Aug 29, 2022
@beliaev-maksim beliaev-maksim deleted the mbeliaev/retry branch August 30, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect error raised when max retries are exceeded
4 participants