install.sh hangs during superuser creation under Docker Compose v2 #1133
Milestone
Comments
|
D'oh! I'm able to repro. Will work on debugging ... |
|
Hrm, something funky with in |
|
Note this though with the workaround:
|
|
This seems to only occur when using |
|
Anything in here look suspicious? What is different when invoked under --- env.working 2021-11-02 17:23:44.000000000 -0400
+++ env.borked 2021-11-02 17:24:18.000000000 -0400
@@ -1,24 +1,31 @@
BLOCKSIZE=K
+COMPOSE_PROJECT_NAME=sentry_onpremise
EDITOR=vim
HOME=/Users/chadwhitacre
LANG=en_US.UTF-8
LESS=--RAW-CONTROL-CHARS --chop-long-lines --LONG-PROMPT
LOGNAME=chadwhitacre
LSCOLORS=gxfxcxdxbxegedabagacad
-OLDPWD=/Users/chadwhitacre
+OLDPWD=/Users/chadwhitacre/workbench/getsentry/onpremise
PAGER=less
PATH=/Users/chadwhitacre/.pyenv/shims:/Users/chadwhitacre/.volta/bin:/Users/chadwhitacre/bin:~/go/bin:/usr/local/opt/bin:/Users/chadwhitacre/.pyenv/shims:/Users/chadwhitacre/.volta/bin:/Users/chadwhitacre/bin:~/go/bin:/usr/local/opt/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Users/chadwhitacre/.cargo/bin:/usr/local/opt/fzf/bin
-PWD=/Users/chadwhitacre/workbench/getsentry/onpremise
+PWD=/Users/chadwhitacre/workbench/getsentry/onpremise/install
PYENV_SHELL=zsh
PYTEST_ADDOPTS=--tb=native --capture=no
PYTHONDONTWRITEBYTECODE=true
+RELAY_IMAGE=getsentry/relay:nightly
+SENTRY_BIND=9000
+SENTRY_EVENT_RETENTION_DAYS=90
+SENTRY_IMAGE=getsentry/sentry:nightly
SENTRY_INSTRUMENTATION=1
SENTRY_POST_MERGE_AUTO_UPDATE=1
SENTRY_SPA_DSN=https://[email protected]/5270453
SHELL=/bin/zsh
-SHLVL=2
+SHLVL=3
+SNUBA_IMAGE=getsentry/snuba:nightly
SSH_AUTH_SOCK=/private/tmp/com.apple.launchd.d4lsA35hGO/Listeners
STY=97460.ttys000.Chads-MBP
+SYMBOLICATOR_IMAGE=getsentry/symbolicator:nightly
TERM=screen
TERMCAP=SC|screen|VT 100/ANSI X3.64 virtual terminal:DO=\E[%dB:LE=\E[%dD:RI=\E[%dC:UP=\E[%dA:bs:bt=\E[Z:cd=\E[J:ce=\E[K:cl=\E[H\E[J:cm=\E[%i%d;%dH:ct=\E[3g:do=^J:nd=\E[C:pt:rc=\E8:rs=\Ec:sc=\E7:st=\EH:up=\EM:le=^H:bl=^G:cr=^M:it#8:ho=\E[H:nw=\EE:ta=^I:is=\E)0:li#45:co#130:am:xn:xv:LP:sr=\EM:al=\E[L:AL=\E[%dL:cs=\E[%i%d;%dr:dl=\E[M:DL=\E[%dM:dc=\E[P:DC=\E[%dP:im=\E[4h:ei=\E[4l:mi:IC=\E[%d@:ks=\E[?1h\E=:ke=\E[?1l\E>:vi=\E[?25l:ve=\E[34h\E[?25h:vs=\E[34l:ti=\E[?1049h:te=\E[?1049l:us=\E[4m:ue=\E[24m:so=\E[3m:se=\E[23m:mb=\E[5m:md=\E[1m:mr=\E[7m:me=\E[m:ms:Co#8:pa#64:AF=\E[3%dm:AB=\E[4%dm:op=\E[39;49m:AX:vb=\Eg:G0:as=\E(0:ae=\E(B:ac=\140\140aaffggjjkkllmmnnooppqqrrssttuuvvwwxxyyzz{{||}}~~..--++,,hhII00:po=\E[5i:pf=\E[4i:Km=\E[M:k0=\E[10~:k1=\EOP:k2=\EOQ:k3=\EOR:k4=\EOS:k5=\E[15~:k6=\E[17~:k7=\E[18~:k8=\E[19~:k9=\E[20~:k;=\E[21~:F1=\E[23~:F2=\E[24~:kB=\E[Z:kh=\E[1~:@1=\E[1~:kH=\E[4~:@7=\E[4~:kN=\E[6~:kP=\E[5~:kI=\E[2~:kD=\E[3~:ku=\EOA:kd=\EOB:kr=\EOC:kl=\EOD:km:
TERM_PROGRAM=Apple_Terminal
@@ -27,6 +34,7 @@
TMPDIR=/var/folders/ky/wbrpvh1s5f12wpt377s3pn3m0000gn/T/
USER=chadwhitacre
VOLTA_HOME=/Users/chadwhitacre/.volta
+WAL2JSON_VERSION=latest
WINDOW=1
XPC_FLAGS=0x0
XPC_SERVICE_NAME=0 |
|
I exported the added envvars into a separate shell and was unable to trigger the bug. |
|
Whittling down a test case ... Steps
ExpectedGet a prompt to create a user account. The prompt accepts input. ActualTerminal gets boogered up, layout goes wonky and is unresponsive, has to be But! If EnvironmentDiffAgainst c16ae02: diff --git a/docker-compose.yml b/docker-compose.yml
index 29342e4..2d21540 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -20,32 +20,8 @@ x-sentry-defaults: &sentry_defaults
depends_on:
redis:
<<: *depends_on-healthy
- kafka:
- <<: *depends_on-healthy
postgres:
<<: *depends_on-healthy
- memcached:
- <<: *depends_on-default
- smtp:
- <<: *depends_on-default
- snuba-api:
- <<: *depends_on-default
- snuba-consumer:
- <<: *depends_on-default
- snuba-outcomes-consumer:
- <<: *depends_on-default
- snuba-sessions-consumer:
- <<: *depends_on-default
- snuba-transactions-consumer:
- <<: *depends_on-default
- snuba-subscription-consumer-events:
- <<: *depends_on-default
- snuba-subscription-consumer-transactions:
- <<: *depends_on-default
- snuba-replacer:
- <<: *depends_on-default
- symbolicator:
- <<: *depends_on-default
entrypoint: "/etc/sentry/entrypoint.sh"
command: ["run", "web"]
environment:
diff --git a/install.sh b/install.sh
index 3886463..c1ac6ee 100755
--- a/install.sh
+++ b/install.sh
@@ -9,21 +9,4 @@ source "$(dirname $0)/install/_lib.sh" # does a `cd .../install/`, among other
source parse-cli.sh
source error-handling.sh
-source check-minimum-requirements.sh
-source create-docker-volumes.sh
-source ensure-files-from-examples.sh
-source generate-secret-key.sh
-source replace-tsdb.sh
-source update-docker-images.sh
-source build-docker-images.sh
-source turn-things-off.sh
-source set-up-zookeeper.sh
-source install-wal2json.sh
-source bootstrap-snuba.sh
-source create-kafka-topics.sh
-source upgrade-postgres.sh
source set-up-and-migrate-database.sh
-source migrate-file-storage.sh
-source relay-credentials.sh
-source geoip.sh
-source wrap-up.sh
diff --git a/install/set-up-and-migrate-database.sh b/install/set-up-and-migrate-database.sh
index 38d4093..3be89ae 100644
--- a/install/set-up-and-migrate-database.sh
+++ b/install/set-up-and-migrate-database.sh
@@ -9,7 +9,9 @@ if [[ -n "${CI:-}" || "${SKIP_USER_PROMPT:-0}" == 1 ]]; then
echo " docker-compose run --rm web createuser"
echo ""
else
- $dcr web upgrade
+ cmd="docker compose --ansi never run --rm web upgrade"
+ echo "$cmd"
+ $cmd
fi
echo "${_endgroup}" |
|
A clue! It's triggered by sourcing |
|
Hah! I bet it's the log redirect. |
|
Yup. 👍 The following works with diff --git a/install.sh b/install.sh
index c1ac6ee..92c9eeb 100755
--- a/install.sh
+++ b/install.sh
@@ -1,12 +1,4 @@
#!/usr/bin/env bash
set -e
-if [[ -n "$MSYSTEM" ]]; then
- echo "Seems like you are using an MSYS2-based system (such as Git Bash) which is not supported. Please use WSL instead.";
- exit 1
-fi
-
-source "$(dirname $0)/install/_lib.sh" # does a `cd .../install/`, among other things
-
-source parse-cli.sh
-source error-handling.sh
-source set-up-and-migrate-database.sh
+exec &> >(tee -a "foo.log")
+docker compose --ansi never run --rm web upgradeOkay! Now what? 🤔 |
|
I think it might be due to this: docker/compose#7306 (comment) |
|
@chadwhitacre can you try with adding |
|
Yeah I tried that based on docker/compose#3106. Didn't help. :-/ |
|
@chadwhitacre that one suggests using both |
|
I tried both ways (both keys, and only tty). |
|
Filed docker/compose#8908. 🤞 ¯\_(ツ)_/¯ |
chadwhitacre
changed the title
This was referenced Nov 9, 2021
Closed
|
Likely related: |
|
@Martmists-GH Did you look at docker/compose#8908 and the test case? It seems related to stdout/err redirection in the shell script that invokes |
Closed
|
Good news! This was fixed in docker/compose#9035. 💃 Once there is a new release of Docker Compose we can close this ticket. 👍 |
|
The fix has landed in docker compose v2.2.3. https://github.com/docker/compose/releases/tag/v2.2.3 |
|
Nice! Thanks for reporting back @GingerAdonis. :) Closing! Will pick up on #1251 ... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Workaround
With Docker Compose < 2.2.1(?):
Docker Compose >= v2.2.1(?) is known to partially work.
Update
Fixed in docker/compose#9035! 💃 Released in 2.2.3. 👍
Original Report
Docker version 20.10.10, build b485636
Docker Compose version v2.0.1
Version
21.10.0
Steps to Reproduce
sudo ./install.sh
Expected Result
Install Success
Actual Result
Running hooks in /etc/ca-certificates/update.d...
done.
02:45:10 [WARNING] sentry.utils.geo: Error opening GeoIP database: /geoip/GeoLite2-City.mmdb
02:45:10 [WARNING] sentry.utils.geo: Error opening GeoIP database in Rust: /geoip/GeoLite2-City.mmdb
02:45:12 [INFO] sentry.plugins.github: apps-not-configured
Running migrations for default
Project Options: N/A% | | ETA: --:--:--
Project Options: 100% |#########################################| Time: 0:00:00
Operations to perform:
Apply all migrations: admin, auth, contenttypes, nodestore, sentry, sessions, sites, social_auth
Running migrations:
Applying sentry.0240_grouphistory_index... OK
Applying sentry.0241_grouphistory_null_actor... OK
Applying sentry.0242_delete_removed_plugin_data... OK
Applying sentry.0243_delete_visualstudio_repo_data... OK
Would you like to create a user account now? [Y/n]:
At this time, the terminal does not respond. There is no choice but to close the terminal. After closing, the log output is as follows
read /dev/stdin: input/output error
The text was updated successfully, but these errors were encountered: