-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use general kafka topic creation in self-hosted #3121
Use general kafka topic creation in self-hosted #3121
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3121 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 3 3
Lines 203 203
=======================================
Hits 201 201
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Nice, love it! A bit weird that this flag is not enabled by default though. |
Reason why I made it an opt-in flag is because this command is used during migration tests and devenv and didn't want to risk breaking anything there. |
* use general kafka topic creation
While upgrading to 24.6.0 i get the following error Error: No such option: --create-kafka-topics
Error in install/set-up-and-migrate-database.sh:30.
'$dcr web upgrade --create-kafka-topics' exited with status 2
-> ./install.sh:main:38
--> install/set-up-and-migrate-database.sh:source:30
Cleaning up... |
I forgot to update the versions in |
Follow up to getsentry/sentry#72338. We can now handle topic creation automatically versus manually listing out topics needed.