-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add insights feature flags #3152
feat: add insights feature flags #3152
Conversation
…ights-initial-modules`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gggritso Does this look right to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add
"projects:span-metrics-extraction"
and "projects:span-metrics-extraction-addons"
🙏🏻
@gggritso Should we also add |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3152 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 3 3
Lines 203 203
=======================================
Hits 201 201
Misses 2 2 ☔ View full report in Codecov by Sentry. |
@aldy505 yes, definitely! Sorry I missed it, I thought it was already there |
@gggritso It turns out the indexed-span-extraction is already there. You can review the PR now. |
@hubertdeng123 Do you want to cut a release for this? Or do you prefer to wait for next month's? |
Closes #3145
After this is merged, we should create a new patch release 24.6.1 to handle that specific issue, since during the time of the self-hosted release, the Insights team ported a few changes from Performance -> Insights.
Also removes
spans-first-ui
per this PR getsentry/sentry#72255Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.