feat(generic-metrics): Add gauges to docker compose, re-try

[ayirr7]

Adding this missing consumer, this is a repeat of #2757

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (da06c0f) to head (1c0faa7).

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3177   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files           3        3           
  Lines         203      203           
=======================================
  Hits          201      201           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aldy505]

Are you sure that you don't want to use rust-consumer?

[ayirr7]

Sorry, let me fix that.

[hubertdeng123]

Wouldn't this also require us to flip the feature flags for custom metrics? Otherwise, what is this consumer used for?

[ayirr7]

Wouldn't this also require us to flip the feature flags for custom metrics?

Could you point me to the feature flags you're referring to? But yes, you are correct that today the gauges consumer is only used by the custom metrics functionality. I reopened this PR as I heard there was interest/questions around using this.

[aldy505]

Wouldn't this also require us to flip the feature flags for custom metrics? Otherwise, what is this consumer used for?

I think it's fine since AFAIK Metrics isn't GA yet. We can add the flags in a separate PR.

[hubertdeng123]

@aldy505 I'd like to avoid adding bloat to the docker compose file if it pertains to a feature that is not yet used.

I believe adding the gauge consumer now is a good idea, since it will ingest some data beforehand, that can be viewed later on the UI when GA's arrived -- so the Metrics UI won't be empty when it's enabled.

@ayirr7 Is this the case here?

[aldy505]

Ping @ayirr7. We are 5 more days until the next release.

[patrickklaeren]

Is there any news on when this might be merged?

I understand this has now missed the window for .7

[ayirr7]

I believe adding the gauge consumer now is a good idea, since it will ingest some data beforehand, that can be viewed later on the UI when GA's arrived -- so the Metrics UI won't be empty when it's enabled.

I believe this should be the case here. The consumer will ingest any relevant data. Once any feature(s) are enabled, they can be used to query the data.

I'm not sure what the timelines are for these features being available/being used. I have asked in relevant spots but have not heard back.

cc @hubertdeng123 , should I go ahead with merging this?

[aldy505]

Thanks Riya! @ayirr7