-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: span normalization allowed host config #3245
base: master
Are you sure you want to change the base?
ref: span normalization allowed host config #3245
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3245 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 3 3
Lines 203 203
=======================================
Hits 201 201
Misses 2 2 ☔ View full report in Codecov by Sentry. |
For those who jumped on enabling this today(don't): |
😆 Sorry about that! |
For those who did that anyway and trying to revert but relay keeps fetching the old config: (resetting/changing the option in sentry.conf.py keeps it in cache and the errors continue)
Do this:
Verify it's set to your "broken" value
Then you can delete it so it's reset on next call
Now relay should fetch the correct config:
Hope that spares someone an hour (or more) |
@Barsoomx the fix is merged and available on Dockerhub if you want to try it. I'm going to try this in a few hours. Use this tag for relay: getsentry/relay:87357fb5e50c9e7e47111709b8a345e778231961 (link: https://hub.docker.com/layers/getsentry/relay/87357fb5e50c9e7e47111709b8a345e778231961/images/sha256-b3ab1bc8336c318d540a610fa2b884ba482f7e252c7b2a14a8129c0f6756afd3?context=explore) |
@hubertdeng123 tested on my instance |
Waiting for PR on
sentry
to be merged first: getsentry/sentry#74195Relay PR: getsentry/relay#3813
Feature request issues: getsentry/relay#3572 and getsentry/relay#3573
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.