Migrate to zookeeper-less kafka #3263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3263 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 3 3
Lines 203 203
=======================================
Hits 201 201
Misses 2 2 ☔ View full report in Codecov by Sentry. |
BYK
reviewed
Aug 13, 2024
install/turn-things-off.sh
Outdated
| @@ -6,6 +6,10 @@ if [[ -n "$MINIMIZE_DOWNTIME" ]]; then | |||
| else | |||
| # Clean up old stuff and ensure nothing is working while we install/update | |||
| $dc down -t $STOP_TIMEOUT --rmi local --remove-orphans | |||
| # TODO(getsentry/self-hosted#2489) | |||
| if docker volume ls | grep -qw sentry-zookeeper; then | |||
| docker volume rm sentry-zookeeper | |||
There was a problem hiding this comment.
Well, I love this that said if the upgrade fails for some reason you have now lost data?
There was a problem hiding this comment.
Moved this removal to the end of the installation then to ensure it will only run if the upgrade succeeds.
|
I just tested this upgrade on our dogfood instance, and it seems to be running successfully |
IanWoodard
approved these changes
Aug 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #2445, which was reverted since it broke existing installs