Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Gradle plugin v2 #50

Merged
merged 29 commits into from
Apr 29, 2021
Merged

Feat: Gradle plugin v2 #50

merged 29 commits into from
Apr 29, 2021

Conversation

marandaneto
Copy link
Contributor

No description provided.

@marandaneto
Copy link
Contributor Author

* Setup a CI build matrix

* Move system.getEnv to buildSrc
@marandaneto
Copy link
Contributor Author

@cortinico CI is not happy because of

Cannot set the value of extension 'sentry' property 'autoUpload' of type java.lang.Boolean using an instance of type java.lang.String.

@marandaneto
Copy link
Contributor Author

throw new Error(Cache upload failed because file read failed with ${error.message});

@cortinico
Copy link
Contributor

throw new Error(Cache upload failed because file read failed with ${error.message});

Those are false negatives from the caching action. I've retriggered them and they're green now.
I'll keep an eye on those if they happen again.

@cerisier
Copy link
Contributor

cerisier commented Apr 10, 2021

@marandaneto @cortinico Can I be of any help to get this merged :)

Right now, the plugin eagerly creates tasks immediatly for all variants, I was about to create a PR to fix just that but stumbled upon this epic PR which effectively solves this as well :)

* Export MappingFileProvider

* Fix PR feedback
* Export PropertiesFileProvider

* Address PR feedback
* Export UploadNativeSymbols to its own task

* Add createTestTask function
@marandaneto
Copy link
Contributor Author

@marandaneto @cortinico Can I be of any help to get this merged :)

Right now, the plugin eagerly creates tasks immediatly for all variants, I was about to create a PR to fix just that but stumbled upon this epic PR which effectively solves this as well :)

hey @cerisier sorry late reply, we're about to release an alpha version by the end of the next week :)
it'd be awesome to get some validation, I'll keep you posted.

@marandaneto marandaneto marked this pull request as ready for review April 29, 2021 08:03
@marandaneto
Copy link
Contributor Author

if it's green, we can merge to master :)

@marandaneto marandaneto merged commit 61b7bef into master Apr 29, 2021
@marandaneto marandaneto deleted the feat/gradle-plugin-v2 branch April 29, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants