-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supply UUID for Proguard Uploads #914
Comments
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Hello! Is this scenario still possible? I'm running into an issue where the UUID in my sentry-debug-meta.properties
We then upload the mapping via sentry-cli We then look into the project on Sentry and the Proguard page shows THE_VALID_UUID. Then I send an event into Sentry and it's still obfsucated and says that I'm missing the correct mapping file We're not sure where this UUID is coming from, but it seems like it is either randomly associated or randomly generated. I am noticing that @kamilogorek moved this to the backlog and removed stale. For possibly helpful additional context, we're uploading the mapping and properties file to a server where we then run sentry-cli to upload it (past our VPNs). Perhaps there's some disassociation happening as a result of that? Thanks so much for the help |
@marandaneto @jan-auer do you know anything about this by any chance? |
Please use the Gradle plugin for generating and uploading the proguard file. In case you wanna upload the proguard file yourself, See this issue. |
@marandaneto , as discussed in this thread: getsentry/sentry-java#1912, we're unable to use the gradle plugin due to our VPN setup. We need to drop the files in a bucket and then run the sentry-cli from that environment.
|
AFAIK, there's nothing broken and everything works as expected, either using the Gradle plugin or sentry-cli directly. |
(Unfortunately, our server is behind a VPN so I wouldn't be able to share/link an issue like you mentioned) Oh, okay, so looking further, instead of --write-properties, our command should look like old: new: Would that be right? |
yes, and use the very same No need of having the |
Wouldn't adding a UUID to the manifest then result in the same UUID for every mapping upload? Is that fine? |
Based on this comment from @marandaneto, the --write-properties syntax is no longer preferred. Instead, use --uuid getsentry/sentry-cli#914 (comment)
--uuid worked for me! I haven't confirmed whether there would be issues on subsequent uploads with the same UUID. @marandaneto might this documentation update make sense then? getsentry/sentry-docs#4764. Apologies if I am violating any practices of this repo, it is my first PR here. |
Every time the mapping file changes, you need to upload it with a new id and update the Manifest with the very same new id too, that's what the Gradle plugin does, automatically. |
Okay good to know, i'll include that in the docs |
* Write Properties is not recommended. Use --uuid Based on this comment from @marandaneto, the --write-properties syntax is no longer preferred. Instead, use --uuid getsentry/sentry-cli#914 (comment) * Update dif.mdx
During Proguard file uploads, sentry-cli computes a hash of the proguard mapping contents and assigns it as UUID for the file. Getting this UUID into SDK configuration during a build is error prone.
Instead, there could be an externally provided random UUID, that sentry-cli attaches the file to. There is precedent for this in the DIF upload, where sentry-cli overrides the identifiers of PDBs.
See getsentry/sentry-android-gradle-plugin#37
The text was updated successfully, but these errors were encountered: