Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Bundle correct sentry-cli os/arch #164

Merged
merged 7 commits into from
Sep 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [macos-latest, windows-latest]
os: [macos-latest, windows-latest, ubuntu-latest]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
Expand All @@ -21,7 +21,7 @@ jobs:
with:
ruby-version: '3.1.2'

- if: matrix.os == 'macos-latest'
- if: matrix.os != 'windows-latest'
name: Install Fastlane {{ matrix.os }}
run: sudo gem install fastlane

Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

### Fixes

- fix: Bundle correct sentry-cli os/arch (#164)

## 1.13.0

### Features
Expand Down
Binary file added bin/sentry-cli-Linux-i686
Binary file not shown.
Binary file added bin/sentry-cli-Linux-x86_64
Binary file not shown.
Binary file added bin/sentry-cli-Windows-i686.exe
Binary file not shown.
16 changes: 13 additions & 3 deletions bin/sentry_cli_path
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,18 @@

require 'os'

if OS.windows?
print File.join(__dir__, 'sentry-cli-Windows-x86_64.exe')
else
if OS.mac?
print File.join(__dir__, 'sentry-cli-Darwin-universal')
elsif OS.windows?
if OS.bits == 64
print File.join(__dir__, 'sentry-cli-Windows-x86_64.exe')
else
print File.join(__dir__, 'sentry-cli-Windows-i686.exe')
end
else
if OS.bits == 64
print File.join(__dir__, 'sentry-cli-Linux-x86_64')
else
print File.join(__dir__, 'sentry-cli-Linux-i686')
end
end
2 changes: 1 addition & 1 deletion fastlane-plugin-sentry.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
spec.homepage = "https://github.com/getsentry/sentry-fastlane-plugin"
spec.license = "MIT"

spec.files = Dir["lib/**/*"] + %w(README.md LICENSE bin/sentry-cli-Darwin-universal bin/sentry-cli-Windows-x86_64.exe)
spec.files = Dir["lib/**/*"] + %w(README.md LICENSE bin/sentry-cli-Darwin-universal bin/sentry-cli-Windows-i686.exe bin/sentry-cli-Windows-x86_64.exe bin/sentry-cli-Linux-i686 bin/sentry-cli-Linux-x86_64)
spec.executables << 'sentry_cli_path'
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
spec.require_paths = ['lib']
Expand Down
2 changes: 1 addition & 1 deletion script/sentry-cli-download.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ function prop {
}

base_url="$(prop 'repo')/releases/download/$(prop 'version')"
platforms=(Darwin-universal Windows-x86_64.exe)
platforms=(Darwin-universal Linux-i686 Linux-x86_64 Windows-i686.exe Windows-x86_64.exe)
target_dir="bin"

for platform in "${platforms[@]}"
Expand Down