Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiling): Introduce continuous profiling mode #2830

Merged
merged 47 commits into from
Jun 11, 2024

Conversation

Zylphrex
Copy link
Member

This is a new profiling mode that is mutually exclusive from the existing profiling modes. In the current profiling modes, a profile is always directly attached to a transaction. This new mode will continuously emit chunks of profiling data that will be connected to the span data.

This is a new profiling mode that is mutually exclusive from the existing
profiling modes. In the current profiling modes, a profile is always directly
attached to a transaction. This new mode will continuously emit chunks of
profiling data that will be connected to the span data.
Zylphrex added a commit that referenced this pull request Mar 18, 2024
As per getsentry/rfc#75, this adds the thread data to the spans. This will be
needed for the continuous profiling mode in #2830.
Zylphrex added a commit that referenced this pull request Mar 20, 2024
As per getsentry/rfc#75, this adds the thread data to the spans. This will be
needed for the continuous profiling mode in #2830.
@Zylphrex Zylphrex marked this pull request as ready for review May 7, 2024 13:44
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, but in general looks great to me

sentry_sdk/continuous_profiler.py Outdated Show resolved Hide resolved
sentry_sdk/client.py Show resolved Hide resolved
sentry_sdk/profiler.py Outdated Show resolved Hide resolved
tests/test_continuous_profiler.py Outdated Show resolved Hide resolved
sentry_sdk/continuous_profiler.py Outdated Show resolved Hide resolved
sentry_sdk/continuous_profiler.py Outdated Show resolved Hide resolved
sentry_sdk/continuous_profiler.py Outdated Show resolved Hide resolved
tests/test_continuous_profiler.py Outdated Show resolved Hide resolved
@Zylphrex Zylphrex requested a review from sentrivana June 6, 2024 20:07
@antonpirker antonpirker added this to the Continuous Profiling milestone Jun 7, 2024
@sentrivana sentrivana merged commit 852cdc7 into master Jun 11, 2024
111 checks passed
@sentrivana sentrivana deleted the txiao/feat/introduce-continuous-profiling-mode branch June 11, 2024 10:29
Zylphrex added a commit that referenced this pull request Jun 11, 2024
The thread data was added to the profile context in #2830. It should live in the
trace context to align with other SDKs.
sentrivana pushed a commit that referenced this pull request Jun 12, 2024
The thread data was added to the profile context in #2830. It should live in the
trace context to align with other SDKs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants