Added option to disable middleware spans in Starlette #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
651
to
658
| idx = 0 | ||
| for span in transaction_event["spans"]: | ||
| if span["op"] == "middleware.starlette": | ||
| assert span["description"] == expected[idx] | ||
| assert span["tags"]["starlette.middleware_name"] == expected[idx] | ||
| if span["op"].startswith("middleware.starlette"): | ||
| assert ( | ||
| span["tags"]["starlette.middleware_name"] | ||
| == expected_middleware_spans[idx] | ||
| ) | ||
| idx += 1 |
There was a problem hiding this comment.
I guess this idx stuff was already here, but maybe we can consider changing this for loop to use zip or enumerate instead, so we can get rid of it?
sentrivana
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
middleware_spansis set toFalse, no spans will be recorded for Starlette middleware. (analogue to how the DjangoIntegration works)Docs update: getsentry/sentry-docs#10523
General Notes
Thank you for contributing to
sentry-python!Please add tests to validate your changes, and lint your code using
tox -e linters.Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.
For maintainers
Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.
Before running sensitive test suites, please carefully check the PR. Then, apply the
Trigger: tests using secretslabel. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.