Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored the Celery Beat integration. #3105

Merged
merged 6 commits into from
Jun 3, 2024
Merged

Refactored the Celery Beat integration. #3105

merged 6 commits into from
Jun 3, 2024

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented May 27, 2024 •
edited
Loading

Making it:

  • to be less error prone
  • correctly propagate trace information to Celery tasks started by Celery beat.

Small docs update to make it clear how trace propagation in Celery works:
getsentry/sentry-docs#10161

@antonpirker antonpirker marked this pull request as draft May 27, 2024 14:31
@antonpirker antonpirker marked this pull request as ready for review May 28, 2024 15:21
sentrivana
sentrivana approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Awesome dedup of the scheduler code too 👍🏻

@sentrivana sentrivana enabled auto-merge (squash) June 3, 2024 09:39
@sentrivana sentrivana merged commit c80cad1 into master Jun 3, 2024
110 checks passed
@sentrivana sentrivana deleted the antonpirker/fix-celery-beat-trace-propagation branch June 3, 2024 09:45
szokeasaurusrex added a commit that referenced this pull request Jun 7, 2024
@szokeasaurusrex
Revert "Refactor the Celery Beat integration (#3105)"
d1a3b57 
This reverts commit c80cad1.
@szokeasaurusrex szokeasaurusrex mentioned this pull request Jun 7, 2024
Merged
szokeasaurusrex added a commit that referenced this pull request Jun 7, 2024
@szokeasaurusrex
Revert "Refactor the Celery Beat integration (#3105)" (#3144)
d818e8f 
This reverts commit c80cad1, which appears to have introduced a regression preventing checkins from being sent when a cron job is finished.
antonpirker added a commit that referenced this pull request Jun 17, 2024
@antonpirker
Reapply "Refactor the Celery Beat integration (#3105)" (#3144)
908ad86 
This reverts commit d818e8f.
antonpirker added a commit that referenced this pull request Jun 18, 2024
@antonpirker
Reapply "Refactor the Celery Beat integration (#3105)" (#3144) (#3175)
009fa4f 
This reverts the revert that was done to mitigate the regression error with Crons not being sending ok/error checkins. This reapplies the refactoring and also fixes the root cause of the regression and also adds integration tests to make sure it does not happen again.
sentrivana pushed a commit that referenced this pull request Jun 19, 2024
@antonpirker @sentrivana
Reapply "Refactor the Celery Beat integration (#3105)" (#3144) (#3175)
af48863 
This reverts the revert that was done to mitigate the regression error with Crons not being sending ok/error checkins. This reapplies the refactoring and also fixes the root cause of the regression and also adds integration tests to make sure it does not happen again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antonpirker @sentrivana