Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pymongo): Add MongoDB collection span tag #3182

Merged
merged 8 commits into from
Jun 25, 2024

Conversation

0Calories
Copy link
Contributor

@0Calories 0Calories commented Jun 18, 2024

Adds the MongoDB collection as a tag on pymongo query spans. The semantics are set to match what is provided by OpenTelemetry: https://opentelemetry.io/docs/specs/semconv/database/mongodb/

@0Calories 0Calories self-assigned this Jun 18, 2024
@0Calories 0Calories changed the title feat(pymongo): Add collection span tag feat(pymongo): Add MongoDB collection span tag Jun 18, 2024
@0Calories 0Calories marked this pull request as ready for review June 18, 2024 22:02
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@antonpirker antonpirker enabled auto-merge (squash) June 25, 2024 06:24
@antonpirker antonpirker merged commit 243e55b into master Jun 25, 2024
110 checks passed
@antonpirker antonpirker deleted the ashanand/pymongo-otel-semantics branch June 25, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants