ref(tests): Unhardcode integration list #3240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3240 +/- ##
==========================================
- Coverage 79.44% 79.34% -0.10%
==========================================
Files 132 132
Lines 14278 14278
Branches 2999 2999
==========================================
- Hits 11343 11329 -14
- Misses 2088 2108 +20
+ Partials 847 841 -6 |
rominf
force-pushed
the
rominf-tests-integration-list
branch
from
15ce0f2
to
da48ec1
Compare
szokeasaurusrex
approved these changes
Jul 15, 2024
auto-merge was automatically disabled
July 15, 2024 15:01
Head branch was pushed to by a user without write access
rominf
force-pushed
the
rominf-tests-integration-list
branch
from
da48ec1
to
33ba99d
Compare
github-actions
bot
removed
the
Trigger: tests using secrets
|
GitHub told to update the branch.
I rebased it on |
|
@szokeasaurusrex It happened again: What should I do? |
|
@rominf I can handle getting the PR merged from here |
Benefits of unhardcoding integration list and disabling auto integrations: 1. It becomes possible to successfully run tests in environments where certain extra auto integrations get enabled. 2. There is no need to update hardcoded list when new default integrations are introduced.
szokeasaurusrex
force-pushed
the
rominf-tests-integration-list
branch
from
33ba99d
to
17e4a77
Compare
szokeasaurusrex
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benefits of unhardcoding integration list and disabling auto integrations:
The origin of this change is a patch that I had to apply while packaging for Fedora: https://src.fedoraproject.org/rpms/python-sentry-sdk/blob/30f00540cd30328d578dfb84625226dcc7f28969/f/python-sentry-sdk.spec#_52 (https://src.fedoraproject.org/rpms/python-sentry-sdk/blob/30f00540cd30328d578dfb84625226dcc7f28969/f/0002-tests.test_new_scopes_compat_event-compatibility.patch). The patch was necessary because all possible optional dependencies for optional integrations are pre-installed as system packages, so that as many tests as possible could be run. Unfortunately, the patch no longer applies to a new version of the Sentry SDK, so instead of redoing the patch in Fedora, I am submitting this PR.
General Notes
Thank you for contributing to
sentry-python!Please add tests to validate your changes, and lint your code using
tox -e linters.Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.
For maintainers
Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.
Before running sensitive test suites, please carefully check the PR. Then, apply the
Trigger: tests using secretslabel. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.