Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(transport): Improve event data category typing #3243

Conversation

szokeasaurusrex
Copy link
Member

Done to more clearly define event data categories, in preparation for #3229.

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/improve-transport-data-category-typing branch from bfe7a59 to 460e508 Compare July 3, 2024 15:40
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.35%. Comparing base (31efa62) to head (854b46c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3243   +/-   ##
=======================================
  Coverage   79.34%   79.35%           
=======================================
  Files         132      132           
  Lines       14227    14227           
  Branches     2987     2987           
=======================================
+ Hits        11289    11290    +1     
+ Misses       2093     2092    -1     
  Partials      845      845           
Files Coverage Δ
sentry_sdk/transport.py 80.73% <50.00%> (+0.26%) ⬆️
sentry_sdk/types.py 75.00% <66.66%> (+3.57%) ⬆️

... and 2 files with indirect coverage changes

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/improve-transport-data-category-typing branch 2 times, most recently from f098e6a to 854b46c Compare July 4, 2024 11:40
Done to more clearly define event data categories, in preparation for #3229.
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/improve-transport-data-category-typing branch from 854b46c to 9b6a718 Compare July 8, 2024 08:52
@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) July 8, 2024 11:54
@szokeasaurusrex szokeasaurusrex merged commit 9b6a718 into master Jul 8, 2024
121 of 122 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/improve-transport-data-category-typing branch July 8, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants