Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Remove Hub from capture_internal_exception logic #3264

Merged
merged 2 commits into from
Jul 10, 2024
Merged

ref: Remove Hub from capture_internal_exception logic #3264

merged 2 commits into from
Jul 10, 2024

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Jul 10, 2024 •
edited
Loading

Prerequisite for #3265

@szokeasaurusrex szokeasaurusrex marked this pull request as draft July 10, 2024 10:20
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/simplify-capture-internal-exceptions branch from a017237 to c42af29 Compare July 10, 2024 10:49
@szokeasaurusrex szokeasaurusrex changed the base branch from master to szokeasaurusrex/improve-ExcInfo-type July 10, 2024 10:50
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review July 10, 2024 10:50
@szokeasaurusrex szokeasaurusrex mentioned this pull request Jul 10, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.35%. Comparing base (1f17f46) to head (f3c8f9f).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3264      +/-   ##
==========================================
- Coverage   79.39%   79.35%   -0.04%     
==========================================
  Files         132      132              
  Lines       14265    14257       -8     
  Branches     2993     2994       +1     
==========================================
- Hits        11326    11314      -12     
  Misses       2094     2094              
- Partials      845      849       +4
Files Coverage Δ
sentry_sdk/hub.py 55.50% <ø> (-0.39%) ⬇️
sentry_sdk/scope.py 85.90% <100.00%> (+0.02%) ⬆️
sentry_sdk/debug.py 91.30% <50.00%> (-5.00%) ⬇️
sentry_sdk/utils.py 82.27% <50.00%> (+0.05%) ⬆️

... and 3 files with indirect coverage changes

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/simplify-capture-internal-exceptions branch from c42af29 to f3c8f9f Compare July 10, 2024 14:11
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/improve-ExcInfo-type branch from 8d691f9 to 1f17f46 Compare July 10, 2024 14:11
Base automatically changed from szokeasaurusrex/improve-ExcInfo-type to master July 10, 2024 14:24
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/simplify-capture-internal-exceptions branch from 4581217 to f3c8f9f Compare July 10, 2024 14:34
@szokeasaurusrex szokeasaurusrex merged commit f3c8f9f into master Jul 10, 2024
238 of 239 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/simplify-capture-internal-exceptions branch July 10, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@szokeasaurusrex @antonpirker