ref(tracing): Remove Hub in Transaction.finish
#3267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
force-pushed
the
szokeasaurusrex/tracing-hub
branch
from
14970d8
to
cfe647f
Compare
antonpirker
approved these changes
Jul 10, 2024
|
|
||
| def finish( | ||
| self, | ||
| scope=None, # type: Optional[sentry_sdk.Scope] |
There was a problem hiding this comment.
The signature of NoOpSpan.finish() probably also needs an update.
Rename `Transaction.finish` method's `hub` parameter to `scope` (in a backwards-compatible manner), and update the method so that it is using `Scope` API under the hood as much as possible. Prerequisite for #3265
Make the same changes previously made to `Transaction.finish`.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/tracing-hub
branch
from
ac75821
to
1c86489
Compare
szokeasaurusrex
changed the base branch from
master
to
szokeasaurusrex/simplify-capture-internal-exceptions
Base automatically changed from
szokeasaurusrex/simplify-capture-internal-exceptions
to
master
July 10, 2024 14:44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
Transaction.finishmethod'shubparameter toscope(in a backwards-compatible manner), and update the method so that it is usingScopeAPI under the hood as much as possible.Prerequisite for #3265