Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(strawberry): Use operation name as transaction name #3294

Merged
merged 8 commits into from
Jul 16, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jul 16, 2024

The Strawberry integration is creating spans at the moment, but they're all grouped under the same /graphql transaction coming from the web framework integration. This has significant effect on the usefulness of tracing.

In this PR, we use the operation name to update the name of the transaction so that each unique operation becomes its own event group.

Closes #3285

@sentrivana sentrivana marked this pull request as ready for review July 16, 2024 13:06
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sentrivana sentrivana enabled auto-merge (squash) July 16, 2024 13:34
@sentrivana sentrivana merged commit cf8e37f into master Jul 16, 2024
122 checks passed
@sentrivana sentrivana deleted the ivana/strawberry-transaction-name branch July 16, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strawberry Integration - Tracing Does Not Appear to Work
2 participants