Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test #3314

Merged
merged 2 commits into from
Jul 22, 2024
Merged

test: fix flaky test #3314

merged 2 commits into from
Jul 22, 2024

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Jul 19, 2024

This test has flaked multiple times on #3311 (see here)

Copy link

codecov bot commented Jul 19, 2024

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 13462 tests with 3 failed, 11651 passed and 1808 skipped.

View the full list of failed tests

py3.6-common

  • Class name: tests.integrations.cloud_resource_context.test_cloud_resource_context
    Test name: test_setup_once[-cloud_resource_context0-False-False]

    .../integrations/cloud_resource_context/test_cloud_resource_context.py:407: in test_setup_once
    fake_warning.assert_not_called()
    .../hostedtoolcache/Python/3.6.15.../x64/lib/python3.6/unittest/mock.py:777: in assert_not_called
    raise AssertionError(msg)
    E AssertionError: Expected 'warning' to not have been called. Called 1 times.

py3.6-gevent

  • Class name: tests.integrations.cloud_resource_context.test_cloud_resource_context
    Test name: test_setup_once[-cloud_resource_context0-False-False]

    .../integrations/cloud_resource_context/test_cloud_resource_context.py:407: in test_setup_once
    fake_warning.assert_not_called()
    .../hostedtoolcache/Python/3.6.15.../x64/lib/python3.6/unittest/mock.py:777: in assert_not_called
    raise AssertionError(msg)
    E AssertionError: Expected 'warning' to not have been called. Called 1 times.

py3.8-common

  • Class name: tests.integrations.cloud_resource_context.test_cloud_resource_context
    Test name: test_setup_once[-cloud_resource_context0-False-False]

    .../integrations/cloud_resource_context/test_cloud_resource_context.py:407: in test_setup_once
    fake_warning.assert_not_called()
    .../hostedtoolcache/Python/3.8.18.../x64/lib/python3.8/unittest/mock.py:874: in assert_not_called
    raise AssertionError(msg)
    E AssertionError: Expected 'warning' to not have been called. Called 1 times.
    E Calls: [call('Can not create a child span for %s. Please start a Sentry transaction before calling this function.', 'time.sleep')].

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/flaky-test branch 2 times, most recently from d6bc2b2 to d4fd563 Compare July 22, 2024 09:27
@szokeasaurusrex szokeasaurusrex marked this pull request as draft July 22, 2024 09:27
auto-merge was automatically disabled July 22, 2024 09:27

Pull request was converted to draft

@szokeasaurusrex szokeasaurusrex changed the title test: fork flaky test test: fix flaky test Jul 22, 2024
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review July 22, 2024 12:34
@szokeasaurusrex szokeasaurusrex merged commit 624e743 into master Jul 22, 2024
123 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/flaky-test branch July 22, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants