Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(onpremise): Support custom CA roots in Docker image #27062

Closed
wants to merge 2 commits into from
Closed

feat(onpremise): Support custom CA roots in Docker image #27062

wants to merge 2 commits into from

Conversation

Spice-King
Copy link

@Spice-King Spice-King commented Jul 1, 2021

Trigger updating the system CA roots if there are local certificates,
and add env vars to override some bundled CA roots.

Result of poking and prodding from #26851
Required for getsentry/self-hosted#1015

Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just need to make sure the command is correct.

docker/docker-entrypoint.sh Outdated Show resolved Hide resolved
@BYK
Copy link
Member

BYK commented Jul 2, 2021

/gcbrun

@BYK
Copy link
Member

BYK commented Jul 8, 2021

/gcbrun

Trigger updating the system CA roots if there are local certificates,
and add env vars to override some bundled CA roots.
auto-merge was automatically disabled July 13, 2021 01:46

Head branch was pushed to by a user without write access

@BYK
Copy link
Member

BYK commented Jul 28, 2021

/gcbrun

@chadwhitacre
Copy link
Member

/gcbrun

@BYK
Copy link
Member

BYK commented Jul 30, 2021

We have decided to isolate this feature and logic over at the onpremise repo as the dynamic volume mount and init in entrypoint are not something everybody might choose (over building their own image for instance).

See getsentry/self-hosted#1015 for more details.

@BYK BYK closed this Jul 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants