llama : fix codeshell support (#8250) #8599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Jul 21, 2024
|
After resolving the conflict from #8609, we can merge |
7 tasks
@ggerganov We have resolve this conflict. Please review and approve it again. Thanks for taking some time to review it! |
ggerganov
reviewed
Jul 22, 2024
|
@ggerganov Sorry for not noticing the order before, we have corrected it. |
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Jul 27, 2024
* llama : fix codeshell support * llama : move codeshell after smollm below to respect the enum order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @ggerganov
We submitted support for CodeShell in PR #5016, but with the update of
llama.cpp, there were some issues with CodeShell support (We have reported this in Issue #8250). This PR aims to sync with the latest version of the repository and fix these issues.