Skip to content

Commit

Permalink
fix(rowDetail): use latest SlickGrid version to fix issue with id (#335)
Browse files Browse the repository at this point in the history
* fix(rowDetail): use latest SlickGrid version to fix issue with id
- there was a small issue in core lib when using "datasetIdPropertyName" other than "id" so update to latest SlickGrid version which has the fix
- change default grid options of Row Detail "useRowClick" property to false

* refactor(core): use latest SlickGrid minor version
  • Loading branch information
ghiscoding committed May 6, 2020
1 parent 23c94f2 commit d89e707
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"jquery-ui-dist": "^1.12.1",
"lodash.isequal": "^4.5.0",
"moment-mini": "^2.24.0",
"slickgrid": "2.4.20",
"slickgrid": "^2.4.22",
"text-encoding-utf-8": "^1.0.2"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions src/aurelia-slickgrid/global-grid-options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -163,13 +163,13 @@ export const GlobalGridOptions: Partial<GridOption> = {
pageSize: 25,
totalItems: 0
},
// @ts-ignore
// technically speaking the Row Detail requires the process & viewComponent but we'll ignore it just to set certain options
// @ts-ignore
rowDetailView: {
cssClass: 'detail-view-toggle',
panelRows: 1,
keyPrefix: '__',
useRowClick: true,
useRowClick: false,
useSimpleViewportCalc: true,
saveDetailViewOnScroll: false,
viewModel: '',
Expand Down

0 comments on commit d89e707

Please sign in to comment.