Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pagination): passing custom pagination sizes should work #342

Merged
merged 1 commit into from
May 15, 2020

Conversation

ghiscoding
Copy link
Owner

  • ref, this bug was mentioned in this Stack Overflow question

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #342 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #342    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          161       161            
  Lines         9486      9485     -1     
  Branches      3063      3168   +105     
==========================================
- Hits          9486      9485     -1     
Impacted Files Coverage Δ
...lia-slickgrid/custom-elements/aurelia-slickgrid.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c942929...24a561f. Read the comment docs.

@ghiscoding ghiscoding merged commit 1ca62a4 into master May 15, 2020
@ghiscoding ghiscoding deleted the bugfix/pagination-custom-page-sizes branch May 15, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant