Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added German locale #290

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

bigbozo
Copy link
Contributor

@bigbozo bigbozo commented Aug 6, 2024

I've added a locale for german language. Example did work as expected.

Copy link

stackblitz bot commented Aug 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

github-actions bot commented Aug 6, 2024

Playwright E2E Test Results

78 tests  ±0   78 ✅ ±0   1m 44s ⏱️ -6s
69 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 3df84a3. ± Comparison against base commit 6eb0bff.

@ghiscoding ghiscoding merged commit 787fb62 into ghiscoding:main Aug 6, 2024
3 checks passed
@ghiscoding
Copy link
Owner

Great thanks for the contribution :)

@bigbozo bigbozo deleted the feature/german-locale branch August 6, 2024 13:14
@ghiscoding ghiscoding changed the title Added German locale feat: Added German locale Aug 6, 2024
@ghiscoding
Copy link
Owner

ghiscoding commented Aug 6, 2024

now available in v3.3.0, thanks again ⭐

Side note, I had to amend the commit title to add the feat: prefix to follow the Conventional Commits for the release to automatically detect & add the commit in the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants