Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(context): when copying use opacity 0 on temp element #534

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Nov 2, 2021

  • we can just use opacity: 0 (transparent) instead of left: -1000px because on computer with high resolution DPI, it might end up showing the temp element we use to copy and we wouldn't want to show it to the user

- we can just use `opacity: 0` instead of `left: -1000px` because on computer with high resolution DPI, it might end up showing the temp element we use to copy and we wouldn't want to show it to the user
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #534 (3f0896f) into master (2721bcb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #534   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          221       221           
  Lines        14065     14064    -1     
  Branches      4805      4805           
=========================================
- Hits         14065     14064    -1     
Impacted Files Coverage Δ
...ages/common/src/extensions/contextMenuExtension.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2721bcb...3f0896f. Read the comment docs.

@AnnetteZhang AnnetteZhang merged commit 04b41fc into master Nov 2, 2021
@AnnetteZhang AnnetteZhang deleted the bugfix/context-menu-copy-command branch November 2, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants