fix(common): calling Date Sorting multiple times was shuffling other lines #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed bug mentioned in Stack Overflow: [question](https://stackoverflow.com/questions/74657131/slickgrid-header-menu-sorting-is-not-working-properly) - for example if we had 10 lines with null values and 90 lines of valid dates, and we were sorting ascending multiple times, the dates were sorted correctly but the 10 null date lines were constantly being shuffled
Codecov Report
@@ Coverage Diff @@
## master #831 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 239 239
Lines 16366 16367 +1
Branches 5778 5777 -1
=========================================
+ Hits 16366 16367 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ghiscoding
changed the title
ghiscoding
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Note that the new code is taking slightly more time to execute because we now create a temp dates to sort nullish values, however it seems negligeable 1240ms vs 1125ms on first sort of 50k unsorted rows (so about 100-150ms longer).