Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicit casting for array operators #24

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

PavloNaumenko
Copy link

You are getting No operator matches the given name and argument types. You might need to add explicit type casts. error when you are trying to use $contArr or $intersectsArr with non-text field type.

@PavloNaumenko
Copy link
Author

Adding new columns with array types is breaking MySQL tests because array types do not support an array data type. Probably I need to remove tests from this PR for now

@afilp
Copy link

afilp commented Jun 1, 2024

@PavloNaumenko Can you please do this so this can be merged? Thanks a lot!

@PavloNaumenko
Copy link
Author

Tests were reverted because used field type not available for MySQL

@coveralls
Copy link

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9658898245

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 98.49%

Files with Coverage Reduction New Missed Lines %
packages/crud-typeorm/src/typeorm-crud.service.ts 2 97.45%
Totals Coverage Status
Change from base Build 9562457195: -0.1%
Covered Lines: 1270
Relevant Lines: 1280

💛 - Coveralls

@zaro zaro merged commit 645b083 into gid-oss:master Jun 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants