Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build broke on Python 3.11 #212

Closed
gilch opened this issue May 25, 2023 · 0 comments · Fixed by #213
Closed

Build broke on Python 3.11 #212

gilch opened this issue May 25, 2023 · 0 comments · Fixed by #213
Labels
automation Tests and workflows and pipelines, oh my bug Something isn't working
Milestone

Comments

@gilch
Copy link
Owner

gilch commented May 25, 2023

The offending change was #205 due to a bad regex using an (?m) flag not at the start. This form had been deprecated and was removed in python/cpython#91222

For those installing master from GitHub, you'll have to use Python 3.8-3.10 or install from earlier commit until I get this fixed (relatively soon).

Fixing the broken line will be easy, but the automation should have caught it. I at least expected a deprecation warning, but maybe I don't have them properly turned on when running tests. Needs more investigation. Python has been going through rolling deprecations and removals lately.

If the warnings prove inadequate, I'm considering doing builds on multiple versions of Python (currently 3.8-3.11). I wonder if there's an easy way to do that in the test-package.yml or if I have to figure out Tox.

I'll also upgrade to 3.9 when 3.8 reaches end-of-support next year. I'm behind the curve to support other Python implementations which tend to lag behind CPython by varying degrees. I'd still be on 3.7 through June but needed features early from 3.8.

@gilch gilch added bug Something isn't working automation Tests and workflows and pipelines, oh my labels May 25, 2023
@gilch gilch added this to the 0.4 milestone May 26, 2023
@gilch gilch mentioned this issue May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Tests and workflows and pipelines, oh my bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant