-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warnings #213
Fix warnings #213
Conversation
Flags not at the start of the expression '\\n$|(?m)^ *;+ ?'
Well, we got there pretty quickly. The warning seems to be in the test runner itself. Maybe I can tweak the config a bit, or ignore warnings just for that package. Might take a few experiments. |
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
===========================================
- Coverage 100.00% 99.71% -0.29%
===========================================
Files 6 6
Lines 706 704 -2
Branches 111 110 -1
===========================================
- Hits 706 702 -4
- Misses 0 1 +1
- Partials 0 1 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Wow, first try. I'm going to swap the order so I don't merge in failing commits. |
Hmm. I maybe lost coverage on a one-line branch in the I'll try removing the default for the |
'hissp.repl' found in sys.modules after import of package 'hissp', but prior to execution of 'hissp.repl'; this may result in 'unpredictable behaviour Remove direct repl entry point. It is no longer required. Use hissp's __main__.py instead.
Fixes #212.
Also configures warnings to fail the workflow, which would have caught this issue, which I confirmed in https://github.com/gilch/hissp/actions/runs/5086943652/jobs/9141865517.
Turns out deprecation warnings don't even print by default. This may turn out to be too strict, but we'll cross that bridge when we come to it.