ci: automagically repackage when Dependabot updates a dependency #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimrul
reviewed
Feb 11, 2024
| - run: npm ci | ||
| - run: npm run build | ||
| - run: npm run lint | ||
| - run: npm run format && git diff-files |
There was a problem hiding this comment.
There is no format script in package.json
There was a problem hiding this comment.
Done. There's also no npm run package.
There was a problem hiding this comment.
The commot message still talks about npm run package
There was a problem hiding this comment.
The commot message still talks about
npm run package
Oops.
dscho
force-pushed
the
npm-run-package-on-dependabot-prs
branch
from
2d1f1d2
to
0dad88c
Compare
Dependabot is really cool and helpful, but sometimes it updates a dependency that requires `npm run prepare` to be run, and Dependabot does not have any way to know that that should happen. Let's have an automated workflow do that, then. This is copied from https://github.com/git-for-windows/setup-git-for-windows-sdk/blob/190c5563/.github/workflows/npm-run-package.yml Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
npm-run-package-on-dependabot-prs
branch
from
0dad88c
to
cc141fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot is really cool and helpful, but sometimes it updates a dependency that requires
npm run packageto be run, and Dependabot does not have any way to know that that should happen.Let's have an automated workflow do that, then.
This is copied from
https://github.com/git-for-windows/setup-git-for-windows-sdk/blob/190c5563/.github/workflows/npm-run-package.yml