Add rollback mechanism for C# buildless #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickfyson
approved these changes
Jun 13, 2024
| [Feature.DisableCsharpBuildless]: { | ||
| defaultValue: false, | ||
| envVar: "CODEQL_ACTION_DISABLE_CSHARP_BUILDLESS", | ||
| minimumVersion: undefined, |
There was a problem hiding this comment.
OOI, why do some need legacyApi: true and some not?
There was a problem hiding this comment.
This is to do with our work to be able to create feature flags without monolith changes. Features with legacyApi: true were added using a monolith PR. Features with legacyApi: false use the new API where the CodeQL Action requests them by name so we don't need to make a monolith PR.
This was referenced Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a rollback mechanism for C# buildless similar to the one we added for Java. When this is enabled, workflows configured to use
build-mode: nonefor C# will usebuild-mode: autobuildinstead.Merge / deployment checklist