Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove C++ TRAP caching feature flag in favour of CLI v2.17.5 check. #2344

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Remove C++ TRAP caching feature flag in favour of CLI v2.17.5 check. #2344

merged 2 commits into from
Jun 18, 2024

Conversation

sashabu
Copy link
Contributor

@sashabu sashabu commented Jun 17, 2024

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@sashabu sashabu requested a review from a team as a code owner June 17, 2024 16:44
@henrymercer
Copy link
Contributor

henrymercer commented Jun 17, 2024 •
edited
Loading

There are some CI errors unrelated to your PR. We have a couple of PRs up to fix that we're just waiting on reviews to merge.

@sashabu sashabu enabled auto-merge June 17, 2024 16:54
auto-merge was automatically disabled June 18, 2024 10:07

Pull Request is not mergeable

@henrymercer henrymercer merged commit ce5603b into main Jun 18, 2024
302 checks passed
@henrymercer henrymercer deleted the sashabu/cpp-trap-cache branch June 18, 2024 12:02
This was referenced Jun 28, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sashabu @henrymercer