Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ SimpleRangeAnalysis: BigInt rewrite experiment #16863

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

C++ SimpleRangeAnalysis: BigInt rewrite experiment #16863

wants to merge 4 commits into from

Conversation

d10c
Copy link
Contributor

@d10c d10c commented Jun 27, 2024

Commits:

  • SimpleRangeAnalysis lib/: float -> BigInt: library changes
  • SimpleRangeAnalysis src/: float -> BigInt: query changes
  • SimpleRangeAnalysis test/: float -> BigInt: test changes

@github-actions github-actions bot added the C++ label Jun 27, 2024
@d10c d10c changed the title SimpleRangeAnalysis: BigInt rewrite experiment C++ SimpleRangeAnalysis: BigInt rewrite experiment Jun 27, 2024
@d10c d10c force-pushed the d10c/simplera-bigint-rewrite branch from b39c714 to 768ee6c Compare June 28, 2024 08:00
@d10c d10c force-pushed the d10c/simplera-bigint-rewrite branch from 768ee6c to 0cee614 Compare July 1, 2024 12:18
@d10c
Update upperBound.expected
dcfc21e 
The new numbers appear to be correct (i.e. actually 2^63-1 or 2^64-1), except for the line 479 which is still within 64-bit range, hence also presumably a bug, assuming we should be able to capture overflow accurately (i.e. not modulo 64-bits).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@d10c