Skip to content

Commit

Permalink
chore: standardize github action types
Browse files Browse the repository at this point in the history
- [x] use one line lists for types and branches
- [x] fix formatting (random 2 space column on some of the workflows)
- [x] add `edited` and `reopened` to some of the workflows

Signed-off-by: jmeridth <[email protected]>
  • Loading branch information
jmeridth committed Jun 7, 2024
1 parent 1f45c76 commit 7e8cd74
Show file tree
Hide file tree
Showing 8 changed files with 30 additions and 35 deletions.
40 changes: 20 additions & 20 deletions .github/workflows/auto-labeler.yml
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
---
name: Auto Labeler
name: Auto Labeler

on:
# pull_request_target event is required for autolabeler to support all PRs including forks
pull_request_target:
types: [opened, reopened, synchronize]
on:
# pull_request_target event is required for autolabeler to support all PRs including forks
pull_request_target:
types: [ opened, reopened, edited, synchronize ]

permissions:
contents: read
permissions:
contents: read

jobs:
main:
permissions:
contents: write
pull-requests: write
name: Auto label pull requests
runs-on: ubuntu-latest
steps:
- uses: release-drafter/release-drafter@3f0f87098bd6b5c5b9a36d49c41d998ea58f9348
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
config-name: release-drafter.yml
jobs:
main:
permissions:
contents: write
pull-requests: write
name: Auto label pull requests
runs-on: ubuntu-latest
steps:
- uses: release-drafter/release-drafter@3f0f87098bd6b5c5b9a36d49c41d998ea58f9348
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
config-name: release-drafter.yml
4 changes: 2 additions & 2 deletions .github/workflows/docker-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ name: Docker Image CI

on:
push:
branches: main
branches: [ main ]
pull_request:
branches: main
branches: [ main ]

permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/major-version-updater.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Major Version Updater
# Whenever a new release is made, push a major version tag
on:
release:
types: published
types: [ published ]

permissions:
contents: read
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/pr-title.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ name: "Lint PR Title"

on:
pull_request_target:
types:
- opened
- edited
- synchronize
types: [ opened, reopened, edited, synchronize ]

permissions:
contents: read
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/python-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ name: Python package

on:
push:
branches: main
branches: [ main ]
pull_request:
branches: main
branches: [ main ]

permissions:
contents: read
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,8 @@
on:
workflow_dispatch:
pull_request_target:
types:
- closed
branches:
- main
types: [ closed ]
branches: [ main ]

permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/scorecard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
schedule:
- cron: '29 11 * * 6'
push:
branches: ["main"]
branches: [ main ]

permissions: read-all

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/super-linter.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Lint Code Base

on:
pull_request:
branches: main
branches: [ main ]

permissions:
contents: read
Expand Down

0 comments on commit 7e8cd74

Please sign in to comment.