Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: hard coded dates to declarative #164

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

zkoppert
Copy link
Member

@zkoppert zkoppert commented Jun 10, 2024

Pull Request

Proposed Changes

This pull request makes changes to the test functions test_get_inactive_repos_with_inactive_repos, test_get_inactive_repos_with_no_organization_set, and test_get_inactive_repos_with_default_branch_updated. The changes consist of replacing a hard-coded date string with a dynamic date value, forty_days_ago.date().isoformat(), for the last_push_date key in the test data. This makes the tests more robust and not reliant on a fixed date.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

@github-actions github-actions bot added the automation automation label Jun 10, 2024
@zkoppert
Copy link
Member Author

I search for "2024 to ensure I got all the instances of this bug across the different test files.

Copy link

@ajhenry ajhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@zkoppert zkoppert enabled auto-merge June 10, 2024 18:16
@zkoppert zkoppert merged commit 5b10d19 into main Jun 10, 2024
26 checks passed
@zkoppert zkoppert deleted the hotfix/hardcoded-dates branch June 10, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants