Add major version updater workflow #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahatzz11
commented
Jun 6, 2023
| echo tag=${tag} | ||
| echo "version=${version} | ||
| echo "major=${major}" | ||
| } >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
@zkoppert The linter forced this syntax, but I personally think this is a case of 'linter makes things less-common and more annoying', vs:
echo "tag=${tag}" >> "$GITHUB_OUTPUT"
echo "version=${version}" >> "$GITHUB_OUTPUT"
echo "major=${major}" >> "$GITHUB_OUTPUT"Happy to keep it as is but thought I'd call it out.
There was a problem hiding this comment.
I agree with you here, I'm disabling that check and reverting to original syntax...
There was a problem hiding this comment.
Nice! Appreciate the change 👍
There was a problem hiding this comment.
Looks like I might not have the rc file in the correct place but i'll get there. 😅
|
@zkoppert I like how this ended with just getting rid of the linter 😂 Thanks for the assist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for creating/overriding a major version when a release is made. This allows people to have a single reference that does not need to be updated in order to get new non-breaking stuff.
Before:
After:
Fixes #26