-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add major version updater workflow #27
Conversation
echo tag=${tag} | ||
echo "version=${version} | ||
echo "major=${major}" | ||
} >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zkoppert The linter forced this syntax, but I personally think this is a case of 'linter makes things less-common and more annoying', vs:
echo "tag=${tag}" >> "$GITHUB_OUTPUT"
echo "version=${version}" >> "$GITHUB_OUTPUT"
echo "major=${major}" >> "$GITHUB_OUTPUT"
Happy to keep it as is but thought I'd call it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you here, I'm disabling that check and reverting to original syntax...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Appreciate the change 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I might not have the rc file in the correct place but i'll get there. 😅
@zkoppert I like how this ended with just getting rid of the linter 😂 Thanks for the assist |
This PR adds support for creating/overriding a major version when a release is made. This allows people to have a single reference that does not need to be updated in order to get new non-breaking stuff.
Before:
After:
Fixes #26