Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deprecated set-output to GITHUB_OUTPUT environment variable #33

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

ahatzz11
Copy link
Contributor

@ahatzz11 ahatzz11 commented Jun 7, 2023

set-output has been marked as deprecated for like 6ish months, so moving from using that to the GITHUB_OUTPUT env var.

@zkoppert For the record, this is how the major-version-updater action works too, for example:

echo "tag=${tag}" >> "$GITHUB_OUTPUT"

GitHub deprecated this last fall and said it would go away this spring but not enough people properly migrated so I think it is postponed for now, but still good to get rid of.

Fixes #31

@ahatzz11 ahatzz11 marked this pull request as ready for review June 7, 2023 13:52
@ahatzz11 ahatzz11 requested a review from zkoppert as a code owner June 7, 2023 13:52
@ahatzz11 ahatzz11 changed the title Change deprecated set-output to GITHUB_OUTPUT env var Change deprecated set-output to GITHUB_OUTPUT environment variable Jun 7, 2023
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I double checked the example in the README.md and it looks that that syntax stays the same.

@zkoppert zkoppert merged commit 026453d into github:main Jun 7, 2023
5 checks passed
@ahatzz11 ahatzz11 deleted the remove-set-output branch June 7, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set-output deprecation
2 participants