return None in case of a github exception for get_active_date #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
occasionally repo.get_branch can raise an exception: github3.exceptions.NotFoundError: 404 Branch not found even will called on the repos default branch
zkoppert
approved these changes
Feb 5, 2024
Signed-off-by: Zack Koppert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Occasionally repo.get_branch can raise an exception:
github3.exceptions.NotFoundError: 404 Branch not foundEven when called on the repo's default branch!
This error handling is a bit overzealous, but I think we want the action to keep trucking along in the event of one repo having an issue.
Proposed Changes
Catch any exeption or error raised by the
github3while trying toget_active_date()and return None for that repo. It's not elegant, but it'll do.Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducingReviewer
bug,documentation,enhancement,infrastructure, orbreaking