-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add repository visibility (public/private) to output #87
Conversation
Looking at error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Small optional suggestion on the naming for readability. Overall great work and Thanks for contributing!
Our priority was to archive public repositories that were not updated in a certain amount of inactive days. This PR adds that information to the output. - [x] update code/tests for new visibility column Signed-off-by: jmeridth <[email protected]>
Signed-off-by: jmeridth <[email protected]>
Signed-off-by: jmeridth <[email protected]> Co-authored-by: Zack Koppert <[email protected]>
bc2c3cd
to
2c543b5
Compare
Signed-off-by: jmeridth <[email protected]>
ok. really broke it. fixing locally and getting my linting check working locally to match remote. 😄 |
Signed-off-by: jmeridth <[email protected]>
Removed the line that I forgot to remove. Now the linter (in GitHub Actions) for this line is saying the closing quote needs to be on a new line. Local syntax does not like that. I can't run |
Signed-off-by: Zack Koppert <[email protected]>
Teamwork! Wohoo! 🎉 |
This will be the 2nd time I've forgotten that GitHub Actions doesn't show |
You've forgotten more than I knew! Haha. I had no idea that was why it did it. I just noticed the make test fail and noticed the output difference. |
Pull Request
Proposed Changes
Our priority was to archive public repositories that were not updated in a certain amount of inactive days. This PR adds that information to the output.
Readiness Checklist
Author/Contributor
make lint
and fix any issues that you have introducedmake test
and ensure you have test coverage for the lines you are introducingReviewer
bug
,documentation
,enhancement
,infrastructure
, orbreaking