Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add repository visibility (public/private) to output #87

Merged
merged 6 commits into from
Mar 1, 2024

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Feb 28, 2024

Pull Request

Proposed Changes

Our priority was to archive public repositories that were not updated in a certain amount of inactive days. This PR adds that information to the output.

  • update code/tests for new visibility column

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, or breaking

@zkoppert zkoppert added the enhancement New feature or request label Feb 29, 2024
@jmeridth
Copy link
Member Author

Looking at error

Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Small optional suggestion on the naming for readability. Overall great work and Thanks for contributing!

stale_repos.py Outdated Show resolved Hide resolved
stale_repos.py Outdated Show resolved Hide resolved
stale_repos.py Outdated Show resolved Hide resolved
stale_repos.py Outdated Show resolved Hide resolved
stale_repos.py Outdated Show resolved Hide resolved
jmeridth and others added 3 commits February 29, 2024 14:05
Our priority was to archive public repositories that were not
updated in a certain amount of inactive days.  This PR adds
that information to the output.

- [x] update code/tests for new visibility column

Signed-off-by: jmeridth <[email protected]>
Signed-off-by: jmeridth <[email protected]>
Co-authored-by: Zack Koppert <[email protected]>
@jmeridth
Copy link
Member Author

ok. really broke it. fixing locally and getting my linting check working locally to match remote. 😄

@jmeridth
Copy link
Member Author

jmeridth commented Feb 29, 2024

Removed the line that I forgot to remove. Now the linter (in GitHub Actions) for this line is saying the closing quote needs to be on a new line. Local syntax does not like that. I can't run make test or make lint (passes locally) without it being on line 910 to close the quoted string. 🤔 🤞 this latest run will pass. 😄

Signed-off-by: Zack Koppert <[email protected]>
@zkoppert
Copy link
Member

zkoppert commented Mar 1, 2024

Teamwork! Wohoo! 🎉

@zkoppert zkoppert merged commit 8625600 into github:main Mar 1, 2024
7 checks passed
@jmeridth jmeridth deleted the jm-include-visibility branch March 1, 2024 06:10
@jmeridth
Copy link
Member Author

jmeridth commented Mar 1, 2024

This will be the 2nd time I've forgotten that GitHub Actions doesn't show \n, it does an actual newline. 🤦 Thank you for getting this closed out @zkoppert. 🙇

@zkoppert
Copy link
Member

zkoppert commented Mar 1, 2024

You've forgotten more than I knew! Haha. I had no idea that was why it did it. I just noticed the make test fail and noticed the output difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants