Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): keyboard shortcut to open app #1260

Merged
merged 9 commits into from
Jun 18, 2024
Merged

Conversation

setchy
Copy link
Member

@setchy setchy commented Jun 17, 2024

revive #1032

closes #995

Changed the shortcut key to be CommandOrControl+Shift+G since CmdOrCtrl+Alt+G is taken by Google Drive on macOS (this explains the previous flickering I reported on #1032).

Screenshot 2024-06-17 at 6 07 12 PM

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Jun 17, 2024
@setchy setchy added this to the Release 5.10.0 milestone Jun 17, 2024
@setchy setchy changed the title feat: keyboard shortcut to open app feat(settings): keyboard shortcut to open app Jun 18, 2024
@afonsojramos
Copy link
Member

What if we give the ability to set the shortcut they want?

@setchy
Copy link
Member Author

setchy commented Jun 18, 2024

What if we give the ability to set the shortcut they want?

We could support that... Could that be a separate enhancement?

main.js Outdated Show resolved Hide resolved
@setchy setchy merged commit 3a31e3e into main Jun 18, 2024
8 checks passed
@setchy setchy deleted the feat/keyboard-shortcut branch June 18, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Keyboard shortcut to open the app
4 participants