-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(biome): enable noConsoleLog rule #1268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that you refactored a console log into its own function to not put the ignore on multiple places is a bit hilarious 😆
just making our friend @bmulholland happy 😄 |
Well, to be fair, I was thinking of going one step further:
The point isn't to centralize the biome-ignore, but more to make the intent clear. Specifically: if I'm reading the code, and I see Also, centralizing it means that we could in future e.g. change the debug log to a log file, which could be submitted with bug reporst. My mental reference here is Rails' log levels: https://guides.rubyonrails.org/debugging_rails_applications.html#sending-messages |
Avoid future
console.logs
accidentally creeping in 🙈