Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: group notifications by repository or date #1273

Merged
merged 13 commits into from
Jun 20, 2024

Conversation

setchy
Copy link
Member

@setchy setchy commented Jun 19, 2024

closes #836.

for now I've added this as another Notification Setting flag.

Screenshot 2024-06-19 at 6 39 56 AM


I've been thinking that in the near future it may make sense to pull out all of our filter-based settings into either their:

  • own settings section ie: Notification Filters
  • dedicated Filters page with access from the sidebar

Types of filter-based settings would include

@setchy setchy added the enhancement New feature or enhancement to existing functionality label Jun 19, 2024
@setchy setchy added this to the Release 5.10.0 milestone Jun 19, 2024
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it is easier to just add a checkbox, but I don't think with a checkbox it is clear what the alternative behaviour is 🤔 Can we use a select instead?

@setchy
Copy link
Member Author

setchy commented Jun 19, 2024

I know it is easier to just add a checkbox, but I don't think with a checkbox it is clear what the alternative behaviour is 🤔 Can we use a select instead?

great feedback. updated to be a radio group

Screenshot 2024-06-19 at 12 25 17 PM

@setchy setchy requested a review from afonsojramos June 19, 2024 22:11
Copy link
Member

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!! I think this will be one that a good subset of users will enjoy!

@afonsojramos afonsojramos merged commit c1ad7a5 into main Jun 20, 2024
8 checks passed
@afonsojramos afonsojramos deleted the feature/group-by-date branch June 20, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: support grouping notifications by date or repository
2 participants