-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: group notifications by repository or date #1273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it is easier to just add a checkbox, but I don't think with a checkbox it is clear what the alternative behaviour is 🤔 Can we use a select instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!! I think this will be one that a good subset of users will enjoy!
closes #836.
for now I've added this as another
Notification Setting
flag.I've been thinking that in the near future it may make sense to pull out all of our filter-based settings into either their:
Notification Filters
Filters
page with access from the sidebarTypes of filter-based settings would include